fix(dev): pin pre-commit's virtualenv to 20.0.23 #19256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful, 20.0.22 is broken because of a change that was merged irresponsibly by virtualenv maintainers. Another nail the coffin to pin virtualenv and be done with it. |
joshuarli
changed the title
billyvg
reviewed
Jun 12, 2020
billyvg
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: pypa/virtualenv#1851
Manifests fatally with our
make setup-giton a fresh (not cached, hence why CI is not failing) venv.Just gonna pin pre-commit's virtualenv to this future release (gonna merge when it gets cut) to try and prevent future breakage. We don't use virtualenv in any way in Sentry.